Skip to content

Increased gRPC message size limit to 16MB / added CLI flag to set the value #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Oct 11, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

  • Increase gRPC message size limit from 4MB to 16MB
  • Added --max-grpc-recv-message-size <SIZE> flag to daemon command

What is the current behavior?

gRPC message size limit is 4MB

What is the new behavior?

gRPC message size limit is 16MB

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

Fix #2718

@cmaglie cmaglie added type: enhancement Proposed improvement topic: gRPC Related to the gRPC interface labels Oct 11, 2024
@cmaglie cmaglie added this to the Arduino CLI v1.1.0 milestone Oct 11, 2024
@cmaglie cmaglie self-assigned this Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.66%. Comparing base (ea09108) to head (082d2a5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/cli/daemon/daemon.go 75.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2729      +/-   ##
==========================================
- Coverage   67.68%   67.66%   -0.02%     
==========================================
  Files         234      234              
  Lines       22285    22298      +13     
==========================================
+ Hits        15083    15089       +6     
- Misses       6017     6022       +5     
- Partials     1185     1187       +2     
Flag Coverage Δ
unit 67.66% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit 0540cee into arduino:master Oct 11, 2024
98 checks passed
@cmaglie cmaglie deleted the increase_grpc_message_size branch October 11, 2024 12:31
@per1234 per1234 added the topic: code Related to content of the project itself label Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation using source override fails if sketch file content longer than maximum gRPC message length
3 participants