Skip to content

Another small gh-action workflow fix. #2682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jul 31, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

A small change in the sync-label workflow: the 'name' value ${{ env.CONFIGURATIONS_ARTIFACT }} would not match the name of the produced intermediate artifacts. The correct pattern is ${{ env.CONFIGURATIONS_ARTIFACT }}-*.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

The previous 'name' value `${{ env.CONFIGURATIONS_ARTIFACT }}` would not
match the name of the produced intermediate artifacts.
The correct pattern is `${{ env.CONFIGURATIONS_ARTIFACT }}-*`.
@cmaglie cmaglie added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Jul 31, 2024
@cmaglie cmaglie self-assigned this Jul 31, 2024
@cmaglie
Copy link
Member Author

cmaglie commented Jul 31, 2024

Test successful:

Run geekyeggo/delete-artifact@v5
  with:
    name: label-configuration-files-*
    token: ***
    useGlob: true
    failOnError: true
  env:
    CONFIGURATIONS_FOLDER: .github/label-configuration-files
    CONFIGURATIONS_ARTIFACT: label-configuration-files
    MERGED_CONFIGURATION_PATH: /home/runner/work/_temp/labels.yml
  
Found [2](https://github.com/arduino/arduino-cli/actions/runs/10181981362/job/28163472580?pr=2682#step:6:2) artifact(s)
Artifact 'label-configuration-files-universal.yml' (ID: 1760459[3](https://github.com/arduino/arduino-cli/actions/runs/10181981362/job/28163472580?pr=2682#step:6:3)00) deleted
Successfully deleted artifact: "label-configuration-files-universal.yml"
Artifact 'label-configuration-files-tooling.yml' (ID: 1760[4](https://github.com/arduino/arduino-cli/actions/runs/10181981362/job/28163472580?pr=2682#step:6:4)59381) deleted
Successfully deleted artifact: "label-configuration-files-tooling.yml"

@cmaglie cmaglie merged commit 43598fc into arduino:master Jul 31, 2024
6 checks passed
@cmaglie cmaglie deleted the small_gh_action_fix branch July 31, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants