grpc: fixed BoardListWatch streaming call #2664
Merged
+30
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
added
type: imperfection
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2664 +/- ##
==========================================
- Coverage 70.27% 70.24% -0.04%
==========================================
Files 222 222
Lines 21347 21346 -1
==========================================
- Hits 15002 14994 -8
- Misses 5159 5174 +15
+ Partials 1186 1178 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
giacomocusinato
approved these changes
Jul 11, 2024
alessio-perugini
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
The gRPC streaming call
BoardListWatchdoes not persist until the client cancels the gRPC call. Instead the call is immediately canceled server side. This is a regression introduced in CLI 1.0.0.What is the current behavior?
The gRPC call
BoardListWatchis canceled server-side almost immediately.What is the new behavior?
The gRPC call
BoardListWatchruns until it is canceled client-side.Does this PR introduce a breaking change, and is titled accordingly?
No
Other information