-
-
Notifications
You must be signed in to change notification settings - Fork 398
use eToken for signing #2599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use eToken for signing #2599
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2599 +/- ##
==========================================
+ Coverage 70.11% 70.13% +0.01%
==========================================
Files 222 222
Lines 21124 21124
==========================================
+ Hits 14812 14816 +4
+ Misses 5135 5132 -3
+ Partials 1177 1176 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…`Could not read certificate from <stdin>`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Infra change
What is the current behavior?
The certificate used to sign windows binaries is expiring, and the provider no longer ships a digital one.
What is the new behavior?
We have setup a local runner used to sign.
Does this PR introduce a breaking change, and is titled accordingly?
no
Other information
TODO:
INSTALLER_CERT_WINDOWS_PFX
and useINSTALLER_CERT_WINDOWS_CER
INSTALLER_CERT_WINDOWS_PASSWORD
INSTALLER_CERT_WINDOWS_CONTAINER