[skip-changelog] fix release CI #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2546 +/- ##
=======================================
Coverage 69.39% 69.39%
=======================================
Files 205 205
Lines 20162 20162
=======================================
Hits 13991 13991
Misses 5044 5044
Partials 1127 1127
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alessio-perugini
approved these changes
Feb 20, 2024
cmaglie
approved these changes
Feb 20, 2024
|
Sorry guys for the mess I did |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
- [ ] Tests for the changes have been added (for bug fixes / features)- [ ] Docs have been added / updated (for bug fixes / features)- [ ]UPGRADING.mdhas been updated with a migration guide (for breaking changes)- [ ]configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Fix CI
What is the current behavior?
The
create-releasestep is not able to authenticate with OIDC to properly obtain credentials.What is the new behavior?
I've moved the permission in the proper section, under the last job. I've also replaced the plugin used to upload file to s3 with the standard s3 commandline
Does this PR introduce a breaking change, and is titled accordingly?
no
Other information