Skip to content

Allow optional programmer in debug command #2544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Feb 19, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

This is a cherry-pick of #2540 from the 0.35.x branch

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

This is a cherry-pick of arduino#2540
from the 0.35.x branch
@cmaglie cmaglie changed the title Allow optional programmer in debug Allow optional programmer in debug command Feb 19, 2024
@cmaglie cmaglie requested a review from a team February 19, 2024 13:23
@cmaglie cmaglie self-assigned this Feb 19, 2024
@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d99184e) 69.42% compared to head (9cda1f7) 69.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2544      +/-   ##
==========================================
- Coverage   69.42%   69.36%   -0.06%     
==========================================
  Files         205      205              
  Lines       20164    20162       -2     
==========================================
- Hits        13999    13986      -13     
- Misses       5044     5052       +8     
- Partials     1121     1124       +3     
Flag Coverage Δ
unit 69.36% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants