Allow empty programmer in debug command
#2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
force-pushed
the
debug_no_programmer
branch
from
345266d to
86f80d1
Compare
cmaglie
force-pushed
the
debug_no_programmer
branch
from
86f80d1 to
de50b32
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.35.x #2540 +/- ##
==========================================
- Coverage 63.69% 63.59% -0.11%
==========================================
Files 206 206
Lines 19487 19485 -2
==========================================
- Hits 12412 12391 -21
- Misses 6012 6031 +19
Partials 1063 1063
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kittaakos
pushed a commit
to arduino/arduino-ide
that referenced
this pull request
Feb 15, 2024
Ref: arduino/arduino-cli#2540 Closes: #2368 Signed-off-by: Akos Kitta <[email protected]>
4 tasks
cmaglie
added
type: enhancement
alessio-perugini
approved these changes
Feb 19, 2024
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this pull request
Feb 19, 2024
This is a cherry-pick of arduino#2540 from the 0.35.x branch
6 tasks
cmaglie
added a commit
that referenced
this pull request
Feb 19, 2024
This is a cherry-pick of #2540 from the 0.35.x branch
kittaakos
pushed a commit
to arduino/arduino-ide
that referenced
this pull request
Feb 19, 2024
Ref: arduino/arduino-cli#2540 Closes: #2368 Signed-off-by: Akos Kitta <[email protected]>
kittaakos
pushed a commit
to arduino/arduino-ide
that referenced
this pull request
Feb 19, 2024
Ref: arduino/arduino-cli#2540 Closes: #2368 Signed-off-by: Akos Kitta <[email protected]>
kittaakos
pushed a commit
to arduino/arduino-ide
that referenced
this pull request
Feb 19, 2024
Ref: arduino/arduino-cli#2540 Closes: #2368 Signed-off-by: Akos Kitta <[email protected]>
kittaakos
pushed a commit
to arduino/arduino-ide
that referenced
this pull request
Feb 19, 2024
Ref: arduino/arduino-cli#2540 Closes: #2368 Signed-off-by: Akos Kitta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Allow optional
programmerin debugging.Normally configurations for debugging are layered one over the other in the following order:
platforms.txtboards.txt(the part relative to the board selected)boards.txt(the parts relative to the board options selected)programmers.txt(the part relative to the programmer selected)BTW some platforms seem to have managed to go without the
programmers.txtfacility. This is a tentative fix to support them.What is the current behavior?
The CLI will fail to debug with the
missing programmererror.What is the new behavior?
The CLI will try to proceed with the debugging anyway.
Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
This PR builds upon Arduino CLI 0.35.2.
@ubidefeo @kittaakos @per1234