Skip to content

Replaced internal serialutils package with the equivalent library #2528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Feb 7, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Just an equivalent code change.

What is the current behavior?

No changes

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 7, 2024
@cmaglie cmaglie requested a review from a team February 7, 2024 14:53
@cmaglie cmaglie self-assigned this Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ec157a8) 68.96% compared to head (af3a39e) 68.99%.
Report is 2 commits behind head on master.

Files Patch % Lines
commands/upload/upload.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2528      +/-   ##
==========================================
+ Coverage   68.96%   68.99%   +0.02%     
==========================================
  Files         204      203       -1     
  Lines       20523    20410     -113     
==========================================
- Hits        14154    14081      -73     
+ Misses       5216     5180      -36     
+ Partials     1153     1149       -4     
Flag Coverage Δ
unit 68.99% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit aa15421 into arduino:master Feb 8, 2024
@cmaglie cmaglie deleted the serialutils branch February 8, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants