Lint tasks refactory #250
Merged
Lint tasks refactory #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
going in the direction of removing travis.ci in favour of drone io, and in order to have a clean linting check output, golangci-lint was removed because the output for this codebase was too confusing
in order to be aligned with test task style we will have a legacy (ugly) lint output if requested and meanwhile we will focus on the "new refactored part" of the code with lint and fmt to speed up the development and refactoring
no need to be obsessed on linting for a module that will be properly refactored out from the legacy
detection in order to do not slow down testing too much also because we do not have particular race conditions to detect at the moment
this is a FIXME commit, in next months all the FIXMEDOCS placeholders must be replaced with proper documentation
|
✅ Build completed. ⬇️ Linux 64: ⬇️ Linux 32: ⬇️ Linux ARM: ⬇️ Windows: ⬇️ OSX: ℹ️ To test this build:
|
masci
approved these changes
Jun 13, 2019
mastrolinux
pushed a commit
that referenced
this pull request
Jul 16, 2019
* replace golangci-lint with govet and golint go-task task going in the direction of removing travis.ci in favour of drone io, and in order to have a clean linting check output, golangci-lint was removed because the output for this codebase was too confusing * refactor task check and add task check-legacy in order to be aligned with test task style we will have a legacy (ugly) lint output if requested and meanwhile we will focus on the "new refactored part" of the code with lint and fmt to speed up the development and refactoring * removed go lint check for legacy lint task no need to be obsessed on linting for a module that will be properly refactored out from the legacy * add dynamic DEFAULT_TARGET generation list * replace golangci-lint with simple go-task check * fix upload for integ and unit test in codeconv.io * raise to 10m test timeput for unit and integ tests * add task test-unit-race to specificly run unit test with rece condition detection in order to do not slow down testing too much also because we do not have particular race conditions to detect at the moment * clean from drone configuration and related dockerfiles * add missing documentation temporary comment to make linter happy this is a FIXME commit, in next months all the FIXMEDOCS placeholders must be replaced with proper documentation
per1234
added a commit
that referenced
this pull request
Aug 9, 2021
…/arduino/go-properties-orderedmap-1.6.0 Bump github.com/arduino/go-properties-orderedmap from 1.4.0 to 1.6.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to remove golangci-lint that is tricky to manage in this development phase, adding specific go-task tasks to check linting. This PR includes
checktasks with separatecheck-legacytask forlegacymodule onlyDEFAULT_TARGETvar