Skip to content

refactoring: Added LibrariesManager.Clone() / Auto-scan libs on LibrariesManager.Build() #2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jan 8, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

This is a code refactoring to improve librariesmanager package.

What is the current behavior?

No user-visible changes

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

No user-facing API change

Other information

@cmaglie cmaglie self-assigned this Jan 8, 2024
@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jan 8, 2024
@cmaglie cmaglie force-pushed the libmnager_improve branch from 3eee9ee to 645c398 Compare January 8, 2024 12:16
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (95753fc) 68.85% compared to head (bcad9c6) 68.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2491      +/-   ##
==========================================
+ Coverage   68.85%   68.87%   +0.02%     
==========================================
  Files         204      204              
  Lines       20465    20472       +7     
==========================================
+ Hits        14091    14100       +9     
+ Misses       5220     5217       -3     
- Partials     1154     1155       +1     
Flag Coverage Δ
unit 68.87% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie marked this pull request as ready for review January 10, 2024 15:28
@cmaglie cmaglie merged commit 51573f2 into arduino:master Jan 11, 2024
@cmaglie cmaglie deleted the libmnager_improve branch January 11, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants