Skip to content

Removed export_cmake hack #2482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Dec 29, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Remove the undocumented export_cmake hack. It's buggy and unmaintained.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Dec 29, 2023
@cmaglie cmaglie self-assigned this Dec 29, 2023
It is buggy, unmaintained and no more used.
@cmaglie cmaglie force-pushed the remove_export_cmake_hack branch from 2f98eea to 42f7b89 Compare December 29, 2023 15:07
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db53f81) 67.61% compared to head (42f7b89) 68.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2482      +/-   ##
==========================================
+ Coverage   67.61%   68.45%   +0.83%     
==========================================
  Files         207      206       -1     
  Lines       20765    20474     -291     
==========================================
- Hits        14041    14015      -26     
+ Misses       5582     5319     -263     
+ Partials     1142     1140       -2     
Flag Coverage Δ
unit 68.45% <ø> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit bba8f72 into arduino:master Jan 2, 2024
@cmaglie cmaglie deleted the remove_export_cmake_hack branch January 2, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants