Refactoring of LibraryManager libraries directory handling. #2477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ruct This is preparatory for the next commit
Previously the libraries detector had to load the single librares provided via '--library' flag after a Rescan, because the library manager wasn't able to handle a single folder library. Now it can so we removed all the tricky machinery.
cmaglie
added
type: enhancement
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2477 +/- ##
==========================================
+ Coverage 67.55% 67.64% +0.09%
==========================================
Files 207 207
Lines 20759 20765 +6
==========================================
+ Hits 14023 14047 +24
+ Misses 5590 5578 -12
+ Partials 1146 1140 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
library_index.jsonURL globalsLibrariesManager.AddLibrariesDirnow accepts explicitLibraryDirstruct parameters--libraryloading hack in the library detectorWhat is the current behavior?
No changes
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information