Reuse archiveCompiledFiles helper for long commandline shrink #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great patch, it's the second code optimization that you found! 👍🏼 BTW there is still a test failing, I'm looking into that. https://github.com/arduino/arduino-cli/actions/runs/7209431432/job/19640374148?pr=2464#step:6:2717 |
cmaglie
added
type: enhancement
cmaglie
force-pushed
the
use_cached_objs_long_commandlines
branch
from
434978c to
4410dc1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2464 +/- ##
==========================================
+ Coverage 67.60% 67.65% +0.05%
==========================================
Files 207 207
Lines 20710 20706 -4
==========================================
+ Hits 14000 14008 +8
+ Misses 5565 5557 -8
+ Partials 1145 1141 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Since archiveCompiledFiles already handles hot cache correctly, this avoids objs.a being rebuilt even if files don't change. Would be ideal if PathList could expose a generic Filter API (to get rid of the "duplicated" filter)
It doesn't make sense anymore to keep path and filename separated.
cmaglie
force-pushed
the
use_cached_objs_long_commandlines
branch
from
a44fb6d to
373e871
Compare
umbynos
approved these changes
Dec 20, 2023
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this pull request
Dec 20, 2023
* Reuse archiveCompiledFiles helper for long commandline shrink Since archiveCompiledFiles already handles hot cache correctly, this avoids objs.a being rebuilt even if files don't change. Would be ideal if PathList could expose a generic Filter API (to get rid of the "duplicated" filter) * Upgrade go-paths / remove duplicate filter function * Consider existing archives during the build * Simplified archiveCompiledFiles function signature It doesn't make sense anymore to keep path and filename separated. * Added integration test --------- Co-authored-by: Cristian Maglie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since archiveCompiledFiles already handles hot cache correctly, this avoids objs.a being rebuilt even if files don't change.
Would be ideal if PathList could expose a generic Filter API (to get rid of the "duplicated" filter) @cmaglie
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Reusing code is always a good idea, particularly if this fixes a missed optimization (the code path for long commandlines was always rebuilding
objs.aeven if the cache was hot)What is the current behavior?
objs.aare always recreated in "long commandline" sketchesWhat is the new behavior?
Cached
objs.aare reused, quite significant speedup for ArduinoIotCloud sketchesDoes this PR introduce a breaking change, and is titled accordingly?
Other information