Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed internally, this PR has the sole purpose of showing one of the options being considered to refactor the code in order to ease maintenance and readability.
The general philosophy is to consider
commands
a service provider to be used by the CLI and possibly by other consumers. Thecommands
public API is mapped with Protocol buffers so that can be consumed through a gRPC client as well. These would be the macro components of the codebase after this refactoring:cli
: implements the CLIcommands
: implements high-level functions used by the CLI and exported through rpcarduino
: implements low-level functions, used bycommands
and go-importable in other projects (provided one knows what they're doing)proto-gen
folders contains the (versioned) generated code of the components we export through rpc (for now, onlycommands
).Implementation-wise, this is the less invasive option, mainly focues on a few things:
Task
to orchestrateprotoc
commands
) so we don't need the root packagerpc
anymorerpc_v1
)daemon
withincommands