Skip to content

Use os.UserHomeDir() for obtaining user's home directory #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

phd
Copy link
Contributor

@phd phd commented Jun 9, 2019

This allows user to use a different directory by exporting own value for the $HOME variable.

Follow up of #169

@phd
Copy link
Contributor Author

phd commented Jun 9, 2019

Unfortunately this one change makes arduino-cli compilation fail on Go 1.10.
And sadly Go 1.12 is not widely adopted yet, e.g. Ubuntu has Go 1.10 available by default in 18.04, 18.10 and latest 19.04 releases: https://packages.ubuntu.com/search?keywords=golang&searchon=names&exact=1&suite=all&section=all (yes, you can easily install Go 1.12, still it's not very convenient)

@masci
Copy link
Contributor

masci commented Jun 10, 2019

Hi @phd thanks for the contribution and thanks for caring about compatibility.

We'll be distributing binaries for the stable releases and we'll pick a specific Go version so the builds can be reproducible. The fact that master doesn't build anymore with an old version of Go has an impact on developers and contributors, not users. IMO asking a bit of extra effort to contributors to install a recent version of Go on systems where it's not yet available is a price we should pay to get a cleaner and more robust codebase.

Hope it makes sense :)

Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@masci masci merged commit 2fbbafa into arduino:master Jun 11, 2019
@cmaglie cmaglie added this to the next alpha milestone Jun 11, 2019
per1234 added a commit that referenced this pull request Aug 9, 2021
Make minor updates/fixes to comments in infrastructure files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants