Skip to content

test: Fixed runners not running 'board' integration test #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2023
Merged

test: Fixed runners not running 'board' integration test #2381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68be030
test: Fixed runners not running 'board' integration test
cmaglie Oct 20, 2023
3fcf4e7
Fixed integration test
cmaglie Nov 10, 2023
7768115
Fixed integration test failure:
cmaglie Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/test-go-task.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,9 @@ jobs:

- name: Collect tests
id: collection
# jq flags must be "-cRn" see: https://stackoverflow.com/a/68859958/1655275
run: |
echo "tests-data=$(go list ./internal/integrationtest/... | grep integrationtest/ | tr "/" " " | cut -d " " -f 6 | jq -cR '[inputs]')" >> $GITHUB_OUTPUT
echo "tests-data=$(go list ./internal/integrationtest/... | grep integrationtest/ | tr "/" " " | cut -d " " -f 6 | jq -cRn '[inputs]')" >> $GITHUB_OUTPUT
test-integration:
needs: tests-collector
Expand Down
1 change: 1 addition & 0 deletions internal/integrationtest/board/board_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,7 @@ func TestCLIStartupWithCorruptedInventory(t *testing.T) {
require.NoError(t, err)
_, err = f.WriteString(`data: '[{"name":"WCH;32?'","fqbn":"esp32:esp32:esp32s3camlcd"}]'`)
require.NoError(t, err)
require.NoError(t, f.Close())

// the CLI should not be able to load inventory and report it to the logs
_, stderr, err := cli.Run("core", "update-index", "-v")
Expand Down
7 changes: 1 addition & 6 deletions internal/integrationtest/board/hardware_loading_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,12 +154,7 @@ func TestHardwareLoading(t *testing.T) {
out, _, err := cli.Run("core", "list", "--format", "json")
require.NoError(t, err)
jsonOut := requirejson.Parse(t, out)
if runtime.GOOS == "windows" {
// a package is a symlink, and windows does not support them
jsonOut.LengthMustEqualTo(2)
} else {
jsonOut.LengthMustEqualTo(3)
}
jsonOut.LengthMustEqualTo(3)
jsonOut.MustContain(`[
{
"id": "arduino:avr",
Expand Down