Skip to content

Fix double 100% progress on CompileResponse #2225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 3, 2023

Conversation

alessio-perugini
Copy link
Contributor

@alessio-perugini alessio-perugini commented Jun 23, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fixes double 100% status on task upgrade when compiling

What is the current behavior?

Right now the builder command calls the runCommands 2 times which leads to having 2 100% values.

What is the new behavior?

The new behavior only sends 1 100% task status and completed property at true when done. I intentionally didn't try to refactor this legacy component.

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@alessio-perugini alessio-perugini added the type: imperfection Perceived defect in any part of project label Jun 23, 2023
@alessio-perugini alessio-perugini self-assigned this Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch coverage: 68.51% and project coverage change: -0.02% ⚠️

Comparison is base (b678f6f) 62.97% compared to head (d1a7a6a) 62.95%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2225      +/-   ##
==========================================
- Coverage   62.97%   62.95%   -0.02%     
==========================================
  Files         220      220              
  Lines       19501    19538      +37     
==========================================
+ Hits        12280    12300      +20     
- Misses       6137     6149      +12     
- Partials     1084     1089       +5     
Flag Coverage Δ
unit 62.95% <68.51%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
arduino/cores/packagemanager/package_manager.go 76.61% <0.00%> (-0.44%) ⬇️
arduino/resources/index.go 46.29% <33.33%> (-2.73%) ⬇️
commands/instances.go 64.43% <64.28%> (-0.27%) ⬇️
legacy/builder/builder.go 84.34% <86.36%> (-0.66%) ⬇️
legacy/builder/container_setup.go 82.35% <100.00%> (-0.99%) ⬇️
legacy/builder/types/context.go 97.61% <100.00%> (+0.08%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessio-perugini alessio-perugini linked an issue Jun 23, 2023 that may be closed by this pull request
3 tasks
@alessio-perugini alessio-perugini force-pushed the improve-compile-response-pb branch 2 times, most recently from a9f606c to c7a7212 Compare June 23, 2023 13:05
@alessio-perugini alessio-perugini requested a review from cmaglie June 23, 2023 13:33
@alessio-perugini alessio-perugini added topic: code Related to content of the project itself topic: CLI Related to the command line interface labels Jul 17, 2023
@umbynos umbynos self-requested a review July 21, 2023 07:44
@alessio-perugini alessio-perugini force-pushed the improve-compile-response-pb branch from 6442ed0 to d1a7a6a Compare August 3, 2023 14:01
@alessio-perugini alessio-perugini merged commit 1923ac4 into master Aug 3, 2023
@alessio-perugini alessio-perugini deleted the improve-compile-response-pb branch August 3, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: CLI Related to the command line interface topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve CompileResponse#progress behavior
3 participants