Skip to content

[skip-changelog] Update expected installed.json after index changes #2218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MatteoPologruto
Copy link
Contributor

@MatteoPologruto MatteoPologruto commented Jun 20, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Infrastructure imperfection fix

What is the new behavior?

Expected installed.json used in integration tests is up-to-date.

Does this PR introduce a breaking change, and is titled accordingly?

No

@MatteoPologruto MatteoPologruto self-assigned this Jun 20, 2023
@MatteoPologruto MatteoPologruto added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Jun 20, 2023
@MatteoPologruto MatteoPologruto marked this pull request as ready for review June 20, 2023 08:35
@MatteoPologruto MatteoPologruto changed the title [skip-changelog] Update expected installed.json after index changes [skip-changelog] Update expected installed.json after index changes Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06 ⚠️

Comparison is base (223d3fa) 62.99% compared to head (81a24c1) 62.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2218      +/-   ##
==========================================
- Coverage   62.99%   62.93%   -0.06%     
==========================================
  Files         220      220              
  Lines       19477    19481       +4     
==========================================
- Hits        12269    12261       -8     
- Misses       6128     6137       +9     
- Partials     1080     1083       +3     
Flag Coverage Δ
unit 62.93% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commands/sketch/new.go 85.71% <100.00%> (+1.50%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MatteoPologruto MatteoPologruto merged commit 642996f into arduino:master Jun 20, 2023
@MatteoPologruto MatteoPologruto deleted the update-expected-installed-json branch June 20, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants