Skip to content

[skip-changelog] Update protobuf deps #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 1, 2023
Merged

Conversation

alessio-perugini
Copy link
Contributor

@alessio-perugini alessio-perugini commented May 31, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Updating some deps regarding protobuf:

go.mod deps:

  • google.golang.org/grpc -> v1.55.0
  • google.golang.org/protobuf -> v1.30.0

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@alessio-perugini alessio-perugini self-assigned this May 31, 2023
@alessio-perugini alessio-perugini added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels May 31, 2023
@alessio-perugini alessio-perugini requested a review from cmaglie May 31, 2023 16:28
@alessio-perugini alessio-perugini marked this pull request as ready for review May 31, 2023 16:28
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.05 🎉

Comparison is base (74dd907) 62.78% compared to head (24819f9) 62.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2196      +/-   ##
==========================================
+ Coverage   62.78%   62.83%   +0.05%     
==========================================
  Files         221      221              
  Lines       19463    19475      +12     
==========================================
+ Hits        12219    12237      +18     
+ Misses       6156     6153       -3     
+ Partials     1088     1085       -3     
Flag Coverage Δ
unit 62.83% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@cmaglie cmaglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@alessio-perugini alessio-perugini merged commit f3ee0a8 into master Jun 1, 2023
@alessio-perugini alessio-perugini deleted the update-protobuf-deps branch June 1, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants