Skip to content

legacy: Arduino preprocess subroutine refactorization (part 5) #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 1, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented May 31, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

This PR is a try to split the bigger PR #2147 into smaller pieces to allow an easier review process.

What is the current behavior?

No changes

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

@cmaglie cmaglie self-assigned this May 31, 2023
@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels May 31, 2023
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage: 81.36% and project coverage change: +0.01 🎉

Comparison is base (0585435) 62.77% compared to head (0bd4f8d) 62.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2195      +/-   ##
==========================================
+ Coverage   62.77%   62.78%   +0.01%     
==========================================
  Files         221      219       -2     
  Lines       19475    19469       -6     
==========================================
- Hits        12225    12224       -1     
+ Misses       6162     6159       -3     
+ Partials     1088     1086       -2     
Flag Coverage Δ
unit 62.78% <81.36%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...egacy/builder/add_additional_entries_to_context.go 62.50% <ø> (+3.87%) ⬆️
legacy/builder/create_cmake_rule.go 9.09% <0.00%> (ø)
legacy/builder/preprocess_sketch.go 0.00% <0.00%> (ø)
legacy/builder/types/context.go 97.53% <ø> (ø)
legacy/builder/utils/utils.go 45.92% <ø> (-1.36%) ⬇️
arduino/builder/sketch.go 54.03% <41.66%> (+1.23%) ⬆️
arduino/builder/preprocessor/ctags.go 77.12% <79.20%> (+9.26%) ⬆️
legacy/builder/builder.go 85.00% <82.35%> (-1.52%) ⬇️
arduino/builder/cpp/cpp.go 92.98% <95.83%> (ø)
...er/preprocessor/internal/ctags/ctags_has_issues.go 98.58% <100.00%> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🌕

@cmaglie cmaglie merged commit 46557b2 into arduino:master Jun 1, 2023
@cmaglie cmaglie deleted the legacy-part5 branch June 1, 2023 07:28
@cmaglie cmaglie changed the title [skip-changelog] legacy: Arduino preprocess subroutine refactorization (part 5) legacy: Arduino preprocess subroutine refactorization (part 5) Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants