[skip-changelog] Issue a warning when the signature verification fails #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
topic: code
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2138 +/- ##
==========================================
- Coverage 62.59% 62.56% -0.03%
==========================================
Files 227 227
Lines 19533 19537 +4
==========================================
- Hits 12226 12224 -2
- Misses 6210 6214 +4
- Partials 1097 1099 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
cmaglie
approved these changes
Apr 7, 2023
umbynos
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Code imperfection fix
What is the current behavior?
The verification of the signature on the package index fails silently.
What is the new behavior?
A warning is issued if the signature verification fails.
Does this PR introduce a breaking change, and is titled accordingly?
No