Compile on freebsd #2116
Merged
Compile on freebsd #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2116 +/- ##
==========================================
+ Coverage 34.95% 34.96% +0.01%
==========================================
Files 232 232
Lines 20570 20570
==========================================
+ Hits 7190 7193 +3
+ Misses 12531 12529 -2
+ Partials 849 848 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Luis Colorado <[email protected]>
cmaglie
force-pushed
the
feat/freebsd_support
branch
from
11372ba to
db6d63d
Compare
cmaglie
added
type: enhancement
cmaglie
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Allows to build the software in freebsd.
What is the current behavior?
On building you get an error on using the default (unimplemented) method for the two new files.
What is the new behavior?
It builds Ok. A link from the linux versions with
_freebsd.gosuffix has been created. Internally the call used in freebsd is the same as the one used in linux.Does this PR introduce a breaking change, and is titled accordingly?
I don't think so.
Other information
N.A.