Remove useless go.mod files in repo / Fix dependabot alerts #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
added
type: enhancement
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2100 +/- ##
==========================================
- Coverage 36.57% 35.05% -1.52%
==========================================
Files 229 232 +3
Lines 19630 20480 +850
==========================================
Hits 7180 7180
- Misses 11605 12455 +850
Partials 845 845
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
cmaglie
force-pushed
the
remove_useless_go_mods
branch
from
310a3f8 to
59b065a
Compare
cmaglie
changed the title
cmaglie
force-pushed
the
remove_useless_go_mods
branch
from
59b065a to
7465cfc
Compare
|
I've added a commit to upgrade |
umbynos
approved these changes
Mar 13, 2023
This was referenced Mar 14, 2023
kittaakos
pushed a commit
to kittaakos/arduino-cli
that referenced
this pull request
Mar 21, 2023
… alerts (arduino#2100) * Removed go.mod from client_example * Removed go.mod from docsgen * Refactored discovery client and removed now useless go.mod files * Updated license cache * Upgraded some dependencies to fix dependabot alerts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Removed some
go.mod/go.sumfiles in subdirectories:client_example/go.mod, is not needed, it just replicates the content of the rootgo.moddocsgen/go.mod, is not needed, it just replicates the content of the rootgo.modarduino/discovery/discovery_client/go.mod, adds a dependency onjiasu.xzqcsaa.nyc.mn/gizak/termui/v3, to remove thego.modfile I've refactored the client and removed thetermuilibrary.The changes above simplifies dependencies management in this repo in case of security upgrades.
Upgraded
golang.org/x/cryptoandgolang.org/x/netto fix dependabot alerts.What is the current behavior?
What is the new behavior?
No changes
Does this PR introduce a breaking change, and is titled accordingly?
No breaking changes.
Other information