[skip-changelog] Add remediation path when tool is not available for an OS #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
type: enhancement
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2092 +/- ##
==========================================
- Coverage 36.43% 36.43% -0.01%
==========================================
Files 229 229
Lines 19586 19587 +1
==========================================
Hits 7137 7137
- Misses 11611 11612 +1
Partials 838 838
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
MatteoPologruto
force-pushed
the
correct-error-dependency-fail
branch
from
bccf0c2 to
83554ba
Compare
MatteoPologruto
force-pushed
the
correct-error-dependency-fail
branch
from
83554ba to
c7aad0c
Compare
MatteoPologruto
force-pushed
the
correct-error-dependency-fail
branch
from
c7aad0c to
11792ed
Compare
MatteoPologruto
changed the title
umbynos
approved these changes
Mar 6, 2023
cmaglie
reviewed
Mar 8, 2023
Comment on lines
+316
to
+317
| return fmt.Errorf(tr("no compatible version of %s tools found for the current os, try contacting %s"), | ||
| toolRelease.Tool.Name, toolRelease.Tool.Package.Email) |
There was a problem hiding this comment.
This string can not be correctly translated, you must replace unindexed %s with %[1]s and %[2]s.
There was a problem hiding this comment.
Modified here: #2099
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Code enhancement
What is the current behavior?
No instructions are provided when a tool download/install fails because it is not available for the OS in use.
What is the new behavior?
The error message has been enhanced by adding the
emailfield of the package that provides the tool.Does this PR introduce a breaking change, and is titled accordingly?
No