Skip to content

[skip-changelog] test: updated tests after index changes #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

Bikappa
Copy link
Contributor

@Bikappa Bikappa commented Feb 27, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull
    Requests

    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fix failing integration test after index update

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@Bikappa Bikappa changed the title test: updated tests after index changes [skip-changelog] test: updated tests after index changes Feb 27, 2023
@Bikappa Bikappa self-assigned this Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 36.56% // Head: 36.54% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (5042b17) compared to base (c95f890).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2088      +/-   ##
==========================================
- Coverage   36.56%   36.54%   -0.02%     
==========================================
  Files         229      229              
  Lines       19538    19538              
==========================================
- Hits         7144     7141       -3     
- Misses      11555    11557       +2     
- Partials      839      840       +1     
Flag Coverage Δ
unit 36.54% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
arduino/cores/packagemanager/package_manager.go 67.46% <0.00%> (-0.73%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Bikappa Bikappa force-pushed the test/fix-failing-test branch from 418bb04 to 5042b17 Compare February 27, 2023 14:20
@Bikappa Bikappa merged commit c660b33 into master Feb 27, 2023
@Bikappa Bikappa deleted the test/fix-failing-test branch February 27, 2023 14:41
@per1234 per1234 added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants