[skip-changelog] Handle repeated builds of a sketch when --build-path target is in the sketch directory
#2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
topic: code
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2084 +/- ##
==========================================
- Coverage 36.46% 36.42% -0.04%
==========================================
Files 229 229
Lines 19558 19578 +20
==========================================
Hits 7131 7131
- Misses 11588 11608 +20
Partials 839 839
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Bikappa
reviewed
Feb 28, 2023
MatteoPologruto
force-pushed
the
repeated-build-path
branch
2 times, most recently
from
e13561b to
ed96ee2
Compare
Bikappa
reviewed
Mar 1, 2023
MatteoPologruto
force-pushed
the
repeated-build-path
branch
from
61560f4 to
d29c379
Compare
Bikappa
approved these changes
Mar 1, 2023
|
Thanks for fixing #1646 ! 👍 ⭐ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Code imperfection fix
What is the current behavior?
It is not possible to build a sketch multiple times when the
--build-pathis the same and is inside the sketch directory. The following error is thrown:It happens because the CLI treats the build directory as part of the sketch itself, therefore it fails when the content of the directory gets deleted/overwritten.
What is the new behavior?
If the
--build-pathtarget already exists and is inside the sketch directory, it is ignored when the sketch instance is created, allowing the user tocompilemultiple times.Does this PR introduce a breaking change, and is titled accordingly?
No