[skip-changelog] Exclude libraries with a missing .h file from lib list
#2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
topic: code
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2083 +/- ##
==========================================
+ Coverage 62.44% 62.56% +0.11%
==========================================
Files 231 231
Lines 19593 19610 +17
==========================================
+ Hits 12235 12269 +34
+ Misses 6254 6238 -16
+ Partials 1104 1103 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
MatteoPologruto
force-pushed
the
lib-list-dot-h
branch
from
14b5c8e to
405e0e1
Compare
cmaglie
requested changes
Mar 15, 2023
MatteoPologruto
force-pushed
the
lib-list-dot-h
branch
2 times, most recently
from
e526800 to
37df1d4
Compare
cmaglie
requested changes
Mar 23, 2023
MatteoPologruto
force-pushed
the
lib-list-dot-h
branch
from
bb30f0a to
b880ec4
Compare
MatteoPologruto
force-pushed
the
lib-list-dot-h
branch
from
b880ec4 to
931c328
Compare
umbynos
approved these changes
Mar 28, 2023
MatteoPologruto
force-pushed
the
lib-list-dot-h
branch
from
3732ae3 to
c3adae2
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Code imperfection fix
What is the current behavior?
Empty folders under
<directories.user>/librariesshow up asis_legacy: truelibraries.What is the new behavior?
Folders that do not contain a
library.propertiesor a.hfile are ignored whenlib listis executed.Does this PR introduce a breaking change, and is titled accordingly?
No