Skip to content

[skip-changelog] Fix upload test according to CLI output refactoring #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

MatteoPologruto
Copy link
Contributor

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Code imperfection fix

What is the current behavior?

TestUploadWithInputDirContainingMultipleBinaries fails because the error output was slightly changed in PR #2003 and no longer contains the message Error during upload.

What is the new behavior?

The test works correctly:

PS C:\Users\m.pologruto\Desktop\Arduino\arduino-cli> go test github.com/arduino/arduino-cli/internal/integrationtest/upload -run TestUploadWithInputDirContainingMultipleBinaries
ok      github.com/arduino/arduino-cli/internal/integrationtest/upload  41.566s

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

No

@MatteoPologruto MatteoPologruto added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Feb 8, 2023
@MatteoPologruto MatteoPologruto self-assigned this Feb 8, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 36.67% // Head: 36.68% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (d5275a4) compared to base (cc24197).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2067      +/-   ##
==========================================
+ Coverage   36.67%   36.68%   +0.01%     
==========================================
  Files         228      228              
  Lines       19383    19383              
==========================================
+ Hits         7108     7111       +3     
+ Misses      11442    11440       -2     
+ Partials      833      832       -1     
Flag Coverage Δ
unit 36.68% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commands/lib/search.go 92.10% <0.00%> (+3.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MatteoPologruto MatteoPologruto merged commit 6bf2c23 into arduino:master Feb 8, 2023
@MatteoPologruto MatteoPologruto deleted the fix-upload-test branch February 8, 2023 13:34
@per1234 per1234 added topic: infrastructure Related to project infrastructure and removed topic: code Related to content of the project itself labels Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants