-
-
Notifications
You must be signed in to change notification settings - Fork 398
[skip changelog] Updated the deprecated ioutil dependency #2054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip changelog] Updated the deprecated ioutil dependency #2054
Conversation
Codecov ReportBase: 36.56% // Head: 36.64% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2054 +/- ##
==========================================
+ Coverage 36.56% 36.64% +0.07%
==========================================
Files 228 228
Lines 19376 19405 +29
==========================================
+ Hits 7084 7110 +26
Misses 11463 11463
- Partials 829 832 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @zachary-walters!
I've added a couple of nitpicks, but for the rest LGTM, we can merge it as soon as you fix them.
Thanks!
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
This change updates the codebase to use alternatives to the ioutil dependency. ioutil has been deprecated since go v1.16.
What is the current behavior?
The current behavior is unchanged.
What is the new behavior?
There is no new behavior
Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
Please see go's official statement about ioutil's deprecation in v1.16: https://go.dev/doc/go1.16#ioutil