Skip to content

[skip-changelog] chore: fix codecov badge url #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

Bikappa
Copy link
Contributor

@Bikappa Bikappa commented Jan 3, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Set the Codecov badge url to point the master branch instead of main, so that the badge image display a valid coverage percentage.

What is the current behavior?

The coverage percentage is "unknown" in the badge
image

What is the new behavior?

Correct information is shown
image

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 36.53% // Head: 36.49% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (e6d2638) compared to base (558130b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2022      +/-   ##
==========================================
- Coverage   36.53%   36.49%   -0.05%     
==========================================
  Files         228      228              
  Lines       19294    19294              
==========================================
- Hits         7050     7041       -9     
- Misses      11413    11420       +7     
- Partials      831      833       +2     
Flag Coverage Δ
unit 36.49% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
arduino/monitor/monitor.go 41.05% <0.00%> (-6.32%) ⬇️
arduino/cores/packagemanager/package_manager.go 66.58% <0.00%> (+0.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Bikappa Bikappa self-assigned this Jan 3, 2023
@Bikappa Bikappa added the type: imperfection Perceived defect in any part of project label Jan 3, 2023
@Bikappa Bikappa requested review from per1234 and cmaglie January 3, 2023 13:11
@Bikappa Bikappa merged commit 50918b4 into master Jan 3, 2023
@Bikappa Bikappa deleted the chore/fix-codecove-badge-url branch January 3, 2023 13:41
@per1234 per1234 added the topic: documentation Related to documentation for the project label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants