Skip to content

chore: prevent empty codecov report #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2023
Merged

chore: prevent empty codecov report #2020

merged 1 commit into from
Jan 3, 2023

Conversation

Bikappa
Copy link
Contributor

@Bikappa Bikappa commented Jan 2, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

The CI pipeline is changed in order to prevent empty Codecov coverage reports. It follows the workaround in the Codecov related issue

What is the current behavior?

Commit related Codecov reports are empty, see example screenshot:
image

What is the new behavior?

Coverage reports are shown correctly by Codecov

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@CLAassistant
Copy link

CLAassistant commented Jan 2, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Base: 0.00% // Head: 36.47% // Increases project coverage by +36.47% 🎉

Coverage data is based on head (f8bdc39) compared to base (357d465).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2020       +/-   ##
===========================================
+ Coverage        0   36.47%   +36.47%     
===========================================
  Files           0      228      +228     
  Lines           0    19294    +19294     
===========================================
+ Hits            0     7038     +7038     
- Misses          0    11422    +11422     
- Partials        0      834      +834     
Flag Coverage Δ
unit 36.47% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...egacy/builder/print_used_and_not_used_libraries.go 100.00% <0.00%> (ø)
cli/core/upgrade.go 0.00% <0.00%> (ø)
commands/board/search.go 0.00% <0.00%> (ø)
arduino/resources/download.go 62.50% <0.00%> (ø)
cli/lib/update_index.go 0.00% <0.00%> (ø)
arduino/builder/compilation_database.go 58.97% <0.00%> (ø)
arduino/libraries/librariesindex/reference.go 100.00% <0.00%> (ø)
version/version.go 64.28% <0.00%> (ø)
i18n/i18n.go 40.00% <0.00%> (ø)
cli/lib/download.go 0.00% <0.00%> (ø)
... and 218 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@per1234 per1234 added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Jan 3, 2023
@cmaglie cmaglie marked this pull request as ready for review January 3, 2023 09:53
@Bikappa Bikappa merged commit 558130b into arduino:master Jan 3, 2023
@Bikappa Bikappa deleted the chore/fix-empty-codecov-report branch January 3, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants