[skip-changelog]Migrate tests from upload_test.py to test_upload.go
#2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
type: enhancement
….py to upload_test.go
… to upload_test.go
…load.py to upload_test.go
…_upload.py to upload_test.go
…go and delete test_upload.py
MatteoPologruto
force-pushed
the
upload-test
branch
from
fcbc9ea to
b4c6049
Compare
cmaglie
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Infrastructure enhancement
What is the new behavior?
Tests that were previously present in
test_upload.pyhave been rewritten inupload_test.go, without changing their original purpose.Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
These tests are not supposed to run on the CI. It would help if you could test them on Ubuntu and macOS.