Skip to content

Small change in upload message #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Nov 24, 2022

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Slightly changes an output message in upload

What is the current behavior?

The "no port found" upload message was:

No upload port found, using address:"/dev/ttyACM0"  protocol:"serial"  as fallback

(notice that the message contains double spaces that are produced pseudo-randomly when a structure is printed using the default String() implementation)

What is the new behavior?

Just print the port address:

No upload port found, using /dev/ttyACM0 as fallback

This is more user-friendly, and the message is 100% reproducible for testing purposes.

Does this PR introduce a breaking change, and is titled accordingly?

No

This produce a more clean output and stabilizes tests.
@cmaglie cmaglie self-assigned this Nov 24, 2022
@cmaglie cmaglie added type: enhancement Proposed improvement priority: high Resolution is a high priority topic: code Related to content of the project itself criticality: low Of low impact labels Nov 24, 2022
@cmaglie cmaglie merged commit d86bc13 into arduino:master Nov 24, 2022
@cmaglie cmaglie deleted the fix_port_stringer branch November 24, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
criticality: low Of low impact priority: high Resolution is a high priority topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants