Skip to content

[skip-changelog] Avoid running publish-go-tester-task if tag is set #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 7, 2022

Conversation

MatteoPologruto
Copy link
Contributor

@MatteoPologruto MatteoPologruto commented Nov 17, 2022

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Infrastructure imperfection fix

What is the current behavior?

publish-go-tester-task runs when a tag is pushed. Since the tag has priority when version is defined, the workflow fails because it does not find any build named test-XXX-git-snapshot when calculating the checksums. It recently happened here: https://github.com/arduino/arduino-cli/actions/runs/3480562942/jobs/5820576240#step:3:16

What is the new behavior?

During run determination, the workflow checks if tag is empty. If not, the run is skipped. Run examples:

Does this PR introduce a breaking change, and is titled accordingly?

No

@MatteoPologruto MatteoPologruto added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Nov 17, 2022
@MatteoPologruto MatteoPologruto self-assigned this Nov 17, 2022
@MatteoPologruto MatteoPologruto marked this pull request as ready for review November 17, 2022 16:43
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umbynos
Copy link
Contributor

umbynos commented Nov 18, 2022

@per1234 should that be mirrored to https://github.com/arduino/tooling-project-assets?

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matteo!

@MatteoPologruto MatteoPologruto merged commit bc5cf6d into arduino:master Dec 7, 2022
@MatteoPologruto MatteoPologruto deleted the fix-tester-build branch December 7, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants