[breaking] Fixed detection of double-install using lib install with --git-url or --zip-path
#1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
added
priority: high
3 tasks
cmaglie
force-pushed
the
fix_git_zip_install
branch
from
22fb998 to
bdf27b0
Compare
The errors are already reported upstream via returned `err` value
It now accepts library name and version as single arguments since we are going to use this function also for libraries not present in the index.
Now it performs all the needed checks to avoid multiple installations.
Now it performs all the needed checks to avoid multiple installations
They were duplicated and spread around all the library install functions.
This helped to find out 2 places where the `installDir` was unnecessary.
cmaglie
force-pushed
the
fix_git_zip_install
branch
from
d4fb7e3 to
174c2db
Compare
The installation folder is now taken from the `name` field in `library.properties`.
umbynos
reviewed
Nov 28, 2022
umbynos
approved these changes
Nov 28, 2022
Co-authored-by: Umberto Baldi <[email protected]>
umbynos
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Fix double install detection running
lib installwith--git-urlor--zip-pathflags.What is the current behavior?
A double-install of a library may be the outcome of
lib installcommand: it happens when a library is installed twice under two different subdirectories of the sketchbook'slibrariesfolder.See #1871 for more details and examples.
What is the new behavior?
The multiple install problem should be fixed.
Does this PR introduce a breaking change, and is titled accordingly?
Yes