Fix concurrency problem in Board.buildConfigOptionsStructures
#1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
added
priority: high
3 tasks
per1234
approved these changes
Nov 14, 2022
There was a problem hiding this comment.
I also was unable to reproduce #1970 but feedback from users who tested unanimously indicates that it does provide the fix and also no regressions were reported:
- Sometimes it will not compile after switching development version #1970 (comment)
- Sometimes it will not compile after switching development version #1970 (comment)
- Sometimes it will not compile after switching development version #1970 (comment)
- https://forum.arduino.cc/t/2-0-1-gets-confused-when-making-new-project/1048866/23
- https://forum.arduino.cc/t/linux-nano-ch340-detected-working-in-ide1-8-13-but-not-ide2-0-1/1048313/19
Thanks for investigating the reports and preparing this fix Cristian!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
This is a tentative fix for #1970
What is the current behavior?
See #1970
What is the new behavior?
Should solve the nil pointer exception reported here: #1970 (comment)
BTW I found no way to reproduce it, so testing is needed.
Does this PR introduce a breaking change, and is titled accordingly?
No