Skip to content

Fixed integration test TestLibInstallMultipleSameLibrary #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Nov 7, 2022

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Fixed an integration test:

<<< Run completed (err = <nil>)
    json.go:90: 
        	Error Trace:	/home/runner/work/arduino-cli/arduino-cli/internal/integrationtest/lib/json.go:90
        	            				/home/runner/work/arduino-cli/arduino-cli/internal/integrationtest/lib/json.go:144
        	            				/home/runner/work/arduino-cli/arduino-cli/internal/integrationtest/lib/lib_test.go:100
        	Error:      	json data length does not match: expected=1, actual=3
        	Test:       	TestLibInstallMultipleSameLibrary
        	Messages:   	A duplicate library install has been detected

https://github.com/arduino/arduino-cli/actions/runs/3410728596/jobs/5674051391#step:6:955

What is the current behavior?

The test fails because a new release of the Arduino SigFox for MKRFox1200 library now has new dependencies.

What is the new behavior?

The test has been refined to actually check for duplicates installations of Arduino SigFox for MKRFox1200 instead of merely counting all the installed libraries.

Does this PR introduce a breaking change, and is titled accordingly?

No breaking changes

@cmaglie cmaglie self-assigned this Nov 7, 2022
@cmaglie cmaglie added priority: high Resolution is a high priority topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project criticality: highest Of highest impact labels Nov 7, 2022
@cmaglie cmaglie merged commit 15d01aa into arduino:master Nov 7, 2022
@cmaglie cmaglie deleted the fix_integration_test branch November 7, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
criticality: highest Of highest impact priority: high Resolution is a high priority topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants