[skip changelog] Fix bugs related to protobuf archive generation #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low jobs GitHub Actions workflows are used to automatically generate nightly builds and production releases of the project. A workflow job is dedicated to the publishing of the build. Previously, this job only needed to download the workflow artifact containing the build filess created by the previous job, generate a checksum file, and upload the builds to Arduino's server. None of these operations had any need for the contents of the repository, so a checkout step was not added to the job. An additional operation was recently added to the publishing job: the generation of archives containing the protocol buffer files to publish along with the builds. This new operation does require the contents of the repository. A checkout step was not added to the job at that time, which caused the protocol buffer generation step and the publishing job to fail: task: No Taskfile found in "/home/runner/work/arduino-cli/arduino-cli". Use "task --init" to create a new one The problem is resolved by adding a step that uses the `actions/checkout` GitHub Actions action to checkout the Arduino CLI repository into the runner machine to make it available for use in that job.
…lder already exists The `protoc:collect` task generates a ZIP archive of the project's protocol buffer files for inclusion with the published builds. In the case of the nightly and release build workflows, the distribution folder the archive is generated into was already created by the build operations in the preceeding workflow job. Previously, the task (and thus entire build workflow) would fail in this case when attempting to create the folder that already exists: mkdir: cannot create directory ‘../dist’: File exists In addition to the obvious purpose, the `--parents` flag of the `mkdir` command also has the following additional effect: > no error if existing So adding this flag to the command resolves the spurious failure. It will create the folder when necessary, but simply carry on with the rest of the task when it does exist.
…ve filename Different version identifiers are used for the build archive filenames depending on the type of build: Local: git-snapshot Tester: test-<reference>-git-snapshot Nightly: nightly-<date> Production: <tag> The use of a nightly build version format is specified by setting the `NIGHTLY` environment variable to `true` in the GitHub Actions workflow. An additional step was recently added to the build workflows: the generation of archives of protocol buffer files to publish along with the builds. The setting of the `NIGHTLY` environment variable in that step was neglected in the nightly build workflow, which caused the protocol buffer archive file to be named with the local build version identifier instead of the nightly build version identifier. This also resulted in the protocol buffer archive file not being added to the checksums file.
per1234
added
topic: infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Infrastructure fix
What is the current behavior?
An additional operation was recently added to the GitHub Actions workflows that produce builds of Arduino CLI: the generation of protocol buffer archive files to publish
along with the builds (#1931).
Some bugs were introduced at that time which caused the nightly build and release workflows to fail.
What is the new behavior?
Fix all the bugs introduced by the previous protocol buffer archive generation work:
Does this PR introduce a breaking change, and is titled accordingly?
No breaking change.
Other information