[skip-changelog] Migrate Lib tests for test_lib.py to lib_test.go
#1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
type: enhancement
MatteoPologruto
force-pushed
the
lib-test
branch
2 times, most recently
from
0c9d2b6 to
5bed052
Compare
MatteoPologruto
force-pushed
the
lib-test
branch
3 times, most recently
from
b2d3d78 to
bce9531
Compare
MatteoPologruto
force-pushed
the
lib-test
branch
from
bce9531 to
a1c4cf1
Compare
MatteoPologruto
force-pushed
the
lib-test
branch
6 times, most recently
from
ffabeba to
d279b27
Compare
cmaglie
requested changes
Dec 12, 2022
…py to lib_test.go
…k from test_lib.py to lib_test.go
…lib.py to lib_test.go
MatteoPologruto
force-pushed
the
lib-test
branch
from
0ba900d to
c0dcc38
Compare
cmaglie
approved these changes
Dec 13, 2022
MatteoPologruto
force-pushed
the
lib-test
branch
from
c0dcc38 to
1a8fe30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Infrastructure enhancement
What is the new behavior?
Tests that were previously present in
test_lib.pyhave been rewritten inlib_test.go, without changing their original purpose.Does this PR introduce a breaking change, and is titled accordingly?
No