Skip to content

Update search.go #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

g-castronovo
Copy link
Contributor

Users opened task inside Transifex for the source file to be in plural.

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Oct 27, 2022
The `lib search` command accepts search keywords as an argument. All libraries with metadata within the search scope
matching those keywords will be returned.

Previously, the error message used the singular form "library". Since the command is as likely to be used to search for
libraries, using the plural form "libraries" is more appropriate.

Users opened a task inside Transifex requesting this change.
@per1234 per1234 force-pushed the g-castronovo/string-79-plural-error branch from ea4968e to 97b0ad9 Compare October 28, 2022 04:22
@per1234 per1234 self-assigned this Oct 28, 2022
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @g-castronovo!

@per1234 per1234 merged commit b759820 into arduino:master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants