[skip-changelog] Migrate tests from test_sketch.py to sketch_test.go
#1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
type: enhancement
cmaglie
requested changes
Oct 27, 2022
| currentSketchPath = currentPath.Join(sketchName) | ||
| stdout, _, err = cli.Run("sketch", "new", currentSketchPath.String()) | ||
| require.NoError(t, err) | ||
| require.Contains(t, string(stdout), "Sketch created in: ", currentSketchPath.String()) |
There was a problem hiding this comment.
Same thing here and all the orher checks in this test
…est_sketch.py to sketch_test.go
…est_sketch.py to sketch_test.go
…ketch.py to sketch_test.go
…est_sketch.py to sketch_test.go
…est_sketch.py to sketch_test.go
…WithoutExtension from test_sketch.py to sketch_test.go
…WithExtension from test_sketch.py to sketch_test.go
…WithoutExtension from test_sketch.py to sketch_test.go
…WithExtension from test_sketch.py to sketch_test.go
…est_sketch.py to sketch_test.go
…est_sketch.py to sketch_test.go
…WithoutExtension from test_sketch.py to sketch_test.go
…WithExtension from test_sketch.py to sketch_test.go
…WithoutExtension from test_sketch.py to sketch_test.go
…WithExtension from test_sketch.py to sketch_test.go
…ch.py to sketch_test.go
…ch.py to sketch_test.go
… from test_sketch.py to sketch_test.go
… from test_sketch.py to sketch_test.go
…WithIncludeBuildDirFlag from test_sketch.py to sketch_test.go
…WithIncludeBuildDirFlag from test_sketch.py to sketch_test.go
…ncludeBuildDirFlag from test_sketch.py to sketch_test.go
…om test_sketch.py to sketch_test.go
…om test_sketch.py to sketch_test.go
…ludeBuildDirFlag from test_sketch.py to sketch_test.go
…ludeBuildDirFlag from test_sketch.py to sketch_test.go
…WithoutExtensionWithIncludeBuildDirFlag from test_sketch.py to sketch_test.go
…WithExtensionWithIncludeBuildDirFlag from test_sketch.py to sketch_test.go
…WithoutExtensionWithIncludeBuildDirFlag from test_sketch.py to sketch_test.go
…WithExtensionWithIncludeBuildDirFlag from test_sketch.py to sketch_test.go
…ludeBuildDirFlag from test_sketch.py to sketch_test.go
…ludeBuildDirFlag from test_sketch.py to sketch_test.go
…WithoutExtensionWithIncludeBuildDirFlag from test_sketch.py to sketch_test.go
…WithExtensionWithIncludeBuildDirFlag from test_sketch.py to sketch_test.go
…WithoutExtensionWithIncludeBuildDirFlag from test_sketch.py to sketch_test.go
…WithExtensionWithIncludeBuildDirFlag from test_sketch.py to sketch_test.go
…te test_sketch.py
MatteoPologruto
force-pushed
the
sketch-test
branch
from
4b48966 to
9471c03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Infrastructure enhancement
What is the new behavior?
This PR is a followup to PR #1806
Integration tests that were previously present in
test_sketch.pyhave been rewritten insketch_test.go, without changing their original purpose.Does this PR introduce a breaking change, and is titled accordingly?
No