[skip-changelog] Migrate tests from test_compile_part_2.py to compile_part_2_test.go
#1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
type: enhancement
Codecov ReportBase: 36.67% // Head: 36.67% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1897 +/- ##
=======================================
Coverage 36.67% 36.67%
=======================================
Files 231 231
Lines 19684 19684
=======================================
Hits 7219 7219
Misses 11635 11635
Partials 830 830
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
MatteoPologruto
force-pushed
the
compile-part-2
branch
3 times, most recently
from
4d473dc to
b16c327
Compare
cmaglie
requested changes
Oct 6, 2022
…ompile_part_2_test.go
… to compile_part_2_test.go
… compile_part_2_test.go
…ile_part_2_test.go
…py to compile_part_2_test.go
to compile_part_2_test.go
… compile_part_2_test.go
…py to compile_part_2_test.go
…d delete test_compile_part_2.py
MatteoPologruto
force-pushed
the
compile-part-2
branch
from
b16c327 to
b36daf2
Compare
cmaglie
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Infrastructure enhancement
What is the new behavior?
This PR is a followup to PR #1806
Integration tests that were previously present in
test_compile_part_2.pyhave been rewritten incompile_part_2_test.go, without changing their original purpose.The tests are the following:
Does this PR introduce a breaking change, and is titled accordingly?
No
See how to contribute