Skip to content

[breaking] Fix behaviour of lib commands when a library is installed multiple times #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 21, 2022
Merged

[breaking] Fix behaviour of lib commands when a library is installed multiple times #1878

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b8187b4
Removed LibraryAlternatives object in favor of libraries.List
cmaglie Sep 15, 2022
04cb693
Use RealName instead of (dir) Name as key in librarymanager.Library map
cmaglie Sep 15, 2022
5ececd3
Refactored some librarymanager functions to query libraries list
cmaglie Sep 15, 2022
7dd0158
Simplified librariesmanager.Install
cmaglie Sep 15, 2022
9d5d575
Added checks for multiple library installation
cmaglie Sep 15, 2022
ac8bc63
Added test to check that the cli is able to handle multiple lib insta…
cmaglie Sep 16, 2022
c3231a3
Renamed fields in Library structure: Name->CanonicalName; RealName->Name
cmaglie Sep 16, 2022
f1e5094
Use Name instead of CanonicalName in LibraryList
cmaglie Sep 16, 2022
1908634
Use `Name` field where appropriate instead of `CanonicalName`
cmaglie Sep 16, 2022
078fd9f
Updated documentation
cmaglie Sep 16, 2022
edad41f
Update arduino/libraries/librarieslist.go
cmaglie Sep 19, 2022
ac3018b
Improved integration test
cmaglie Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions internal/integrationtest/lib/lib_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,3 +93,27 @@ func TestLibInstallMultipleSameLibrary(t *testing.T) {
require.NoError(t, err)
requirejson.Len(t, jsonOut, 1, "A duplicate library install has been detected")
}

func TestDuplicateLibInstallDetection(t *testing.T) {
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
defer env.CleanUp()
cliEnv := cli.GetDefaultEnv()
cliEnv["ARDUINO_LIBRARY_ENABLE_UNSAFE_INSTALL"] = "true"

// Make a double install in the sketchbook/user directory
_, _, err := cli.Run("lib", "install", "[email protected]")
require.NoError(t, err)
otaLibPath := cli.SketchbookDir().Join("libraries", "ArduinoOTA")
err = otaLibPath.CopyDirTo(otaLibPath.Parent().Join("CopyOfArduinoOTA"))
require.NoError(t, err)
jsonOut, _, err := cli.Run("lib", "list", "--format", "json")
require.NoError(t, err)
requirejson.Len(t, jsonOut, 2, "Duplicate library install is not detected by the CLI")

_, _, err = cli.Run("lib", "install", "ArduinoOTA")
require.Error(t, err)
_, _, err = cli.Run("lib", "upgrade", "ArduinoOTA")
require.Error(t, err)
_, _, err = cli.Run("lib", "uninstall", "ArduinoOTA")
require.Error(t, err)
}