Skip to content

integration test: Added function to run arduino-cli with custom env #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Sep 15, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?
    Added an helper function to run arduino-cli with custom env
  • What is the current behavior?
    No changes
  • What is the new behavior?
    No changes

@cmaglie cmaglie force-pushed the add_env_integration_test branch from 5345553 to e07d9af Compare September 15, 2022 08:55
@cmaglie cmaglie force-pushed the add_env_integration_test branch from e07d9af to de86966 Compare September 15, 2022 08:55
@cmaglie cmaglie self-assigned this Sep 15, 2022
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 36.66% // Head: 36.66% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (de86966) compared to base (736608f).
Patch coverage: 71.42% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1877      +/-   ##
==========================================
- Coverage   36.66%   36.66%   -0.01%     
==========================================
  Files         231      231              
  Lines       19666    19680      +14     
==========================================
+ Hits         7211     7216       +5     
- Misses      11627    11635       +8     
- Partials      828      829       +1     
Flag Coverage Δ
unit 36.66% <71.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/integrationtest/arduino-cli.go 82.57% <71.42%> (-1.43%) ⬇️
arduino/cores/packagemanager/package_manager.go 65.82% <0.00%> (-0.76%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cristian!

@cmaglie cmaglie merged commit 7d1916d into arduino:master Sep 15, 2022
@cmaglie cmaglie deleted the add_env_integration_test branch September 15, 2022 09:19
@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants