[skip-changelog] Migrate tests from test_completion.py to completion_test.go
#1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
type: enhancement
Codecov Report
@@ Coverage Diff @@
## master #1844 +/- ##
==========================================
+ Coverage 36.37% 36.39% +0.01%
==========================================
Files 231 231
Lines 19572 19572
==========================================
+ Hits 7120 7123 +3
+ Misses 11622 11620 -2
+ Partials 830 829 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MatteoPologruto
force-pushed
the
completion-test-go
branch
from
2beac6c to
a5d1de4
Compare
MatteoPologruto
changed the title
test_completion.py to completion_test.gotest_completion.py to completion_test.go
MatteoPologruto
force-pushed
the
completion-test-go
branch
from
a5d1de4 to
9c4422b
Compare
umbynos
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Infrastructure enhancement
What is the new behavior?
This PR is a followup to PR #1806
Integration tests that were previously present in
test_completion.pyhave been rewritten incompletion_test.go, without changing their original purpose.The tests are the following:
I could not find a way to correctly implement the
hide=trueflag present in the first half of the commands of the original TestLibCompletion, so I omitted it while rewriting them. For example:result = run_command(["__complete", "lib", "install", ""], hide=True)has simply been rewritten as
stdout, _, _ := cli.Run("__complete", "lib", "install", "")If you have any suggestions, I will modify the corresponding commit.
Does this PR introduce a breaking change, and is
titled accordingly?
No
See how to contribute