Skip to content

[skip-changelog] Try to whitelist CI for Cloudflare spam-check filters #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jul 8, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?
Add a secret token to the User Agent to bypass Cloudflare spam-check filters

cmaglie added 2 commits July 8, 2022 15:52
This will allow to possibly bypass spam-checks on the server side
reducing the jobs failures due to rate limiting.
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #1796 (696e625) into master (6ac5f7a) will increase coverage by 0.00%.
The diff coverage is 57.14%.

@@           Coverage Diff           @@
##           master    #1796   +/-   ##
=======================================
  Coverage   35.70%   35.70%           
=======================================
  Files         231      231           
  Lines       19463    19468    +5     
=======================================
+ Hits         6950     6952    +2     
- Misses      11695    11697    +2     
- Partials      818      819    +1     
Flag Coverage Δ
unit 35.70% <57.14%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
configuration/network.go 51.51% <57.14%> (-2.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ac5f7a...696e625. Read the comment docs.

@cmaglie cmaglie marked this pull request as ready for review July 8, 2022 14:56
@cmaglie
Copy link
Member Author

cmaglie commented Jul 8, 2022

I've got confirmation that the token is passing through.

@cmaglie cmaglie requested a review from a team July 8, 2022 14:57
@cmaglie cmaglie self-assigned this Jul 8, 2022
@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure topic: code Related to content of the project itself labels Jul 8, 2022
@cmaglie cmaglie merged commit 38ee95c into master Jul 11, 2022
@cmaglie cmaglie deleted the firewall_whitelist branch July 11, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants