-
-
Notifications
You must be signed in to change notification settings - Fork 398
Add support for macos arm64 build #1770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
057ce7d
to
7bde16c
Compare
- the gon config is now hardcoded in the workflow (it allows customization) - the notarization step is run in parallel now - the updated checksum is passed to the `create-release` job - the `create-release` job handles the checksum update in `checksum.txt` file
This reverts commit c4fd700.
7bde16c
to
74889c3
Compare
Test release with s3 push disabled here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The additional links should be added to the release and nightly build tables in this document:
https://github.com/arduino/arduino-cli/blob/master/docs/installation.md
Co-authored-by: per1234 <[email protected]>
7a9903c
to
b36c4f7
Compare
The check links workflow is expected to fail, since https://downloads.arduino.cc/arduino-cli/arduino-cli_latest_macOS_ARM64.tar.gz and https://downloads.arduino.cc/arduino-cli/nightly/arduino-cli_nightly-latest_macOS_ARM64.tar.gz do not exixts yet |
Co-authored-by: per1234 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work Umberto! The notarization job matrix is especially impressive.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)feature
We do not provide build for macos arm64 (M1)
The CI is able to release macos arm64 binaries. Furthermore:
macOS_ARM64
create-release
jobcreate-release
job handles the checksum update inchecksum.txt
filetitled accordingly?
no
See how to contribute