Skip to content

Add support for macos arm64 build #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 22, 2022
Merged

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Jun 16, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

feature

  • What is the current behavior?

We do not provide build for macos arm64 (M1)

  • What is the new behavior?

The CI is able to release macos arm64 binaries. Furthermore:

  • the Taskfile now supports macOS_ARM64
  • the gon config is now hardcoded in the workflow (it allows customization)
  • the notarization step is run in parallel now
  • the updated checksum is passed to the create-release job
  • the create-release job handles the checksum update in checksum.txt file
  • Does this PR introduce a breaking change, and is
    titled accordingly?

no

  • Other information:

See how to contribute

@umbynos umbynos added os: macos Specific to macOS operating system architecture: arm64 Specific to 64 bit ARM host architecture topic: infrastructure Related to project infrastructure topic: packaging Related to the release distribution package labels Jun 16, 2022
@umbynos umbynos self-assigned this Jun 16, 2022
@umbynos umbynos force-pushed the umbynos/darwin_arm64 branch 5 times, most recently from 057ce7d to 7bde16c Compare June 17, 2022 10:00
umbynos added 5 commits June 17, 2022 15:09
- the gon config is now hardcoded in the workflow (it allows customization)
- the notarization step is run in parallel now
- the updated checksum is passed to the `create-release` job
- the `create-release` job handles the checksum update in `checksum.txt` file
@umbynos umbynos force-pushed the umbynos/darwin_arm64 branch from 7bde16c to 74889c3 Compare June 17, 2022 13:09
@umbynos umbynos requested a review from per1234 June 17, 2022 14:43
@umbynos
Copy link
Contributor Author

umbynos commented Jun 17, 2022

Test release with s3 push disabled here

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional links should be added to the release and nightly build tables in this document:

https://github.com/arduino/arduino-cli/blob/master/docs/installation.md

@umbynos umbynos force-pushed the umbynos/darwin_arm64 branch from 7a9903c to b36c4f7 Compare June 22, 2022 12:47
@umbynos
Copy link
Contributor Author

umbynos commented Jun 22, 2022

@umbynos umbynos requested a review from per1234 June 22, 2022 12:54
@per1234 per1234 linked an issue Jun 22, 2022 that may be closed by this pull request
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work Umberto! The notarization job matrix is especially impressive.

@umbynos umbynos merged commit 0de6c37 into arduino:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture: arm64 Specific to 64 bit ARM host architecture os: macos Specific to macOS operating system topic: infrastructure Related to project infrastructure topic: packaging Related to the release distribution package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add native support for Apple Silicon
2 participants