Skip to content

Fixed initialization of profile libraries #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented May 25, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?
Globally installed libraries should be ignored if profiles are in use.

What is the current behavior?
Globally installed libraries are not ignored.

What is the new behavior?
Globally installed libraries are ignored.

Does this PR introduce a breaking change, and is titled accordingly?
No

@cmaglie cmaglie self-assigned this May 25, 2022
@cmaglie cmaglie requested a review from a team May 25, 2022 12:18
@cmaglie cmaglie added the criticality: highest Of highest impact label May 25, 2022
@cmaglie cmaglie added this to the arduino-cli 0.22.0 milestone May 25, 2022
@cmaglie cmaglie force-pushed the fix_profiles_lib branch from 2f8414f to 510da14 Compare May 25, 2022 12:21
@cmaglie cmaglie force-pushed the fix_profiles_lib branch from 510da14 to 017d361 Compare May 25, 2022 12:23
@cmaglie cmaglie removed this from the arduino-cli 0.22.0 milestone May 25, 2022
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels May 25, 2022
@umbynos umbynos changed the title Fixed initializaion of profile libraries Fixed initialization of profile libraries May 25, 2022
The library must be installed globally in order to provide coverage of the bug.

Co-authored-by: per1234 <[email protected]>
@cmaglie cmaglie merged commit f0245bc into arduino:master May 25, 2022
@cmaglie cmaglie deleted the fix_profiles_lib branch May 25, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
criticality: highest Of highest impact topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants