Skip to content

add flag to allow board options to be specified seperately from fqbn #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Mar 9, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

feature

  • What is the current behavior?

The only way to specify board options is by appending them along with the fqbn

  • What is the new behavior?

I've added a CLI flag (--board-options) that allows to specify additional options separately from the FQBN. Of course, the old way of adding options along the FQBN is still supported. I've added this possibility because the secureboot will work with a specific board property security=sien(signature and encryption) in order to use it.

  • Other information:

See how to contribute

@umbynos umbynos requested a review from cmaglie March 9, 2022 11:55
@umbynos umbynos self-assigned this Mar 9, 2022
@umbynos umbynos added topic: CLI Related to the command line interface topic: code Related to content of the project itself type: enhancement Proposed improvement labels Mar 9, 2022
@umbynos umbynos force-pushed the umbynos/board_options branch 2 times, most recently from 5bf689b to 3af30e4 Compare March 10, 2022 11:05
Copy link
Member

@cmaglie cmaglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added just a nitpick for code formatting, but overall LGTM 👍🏼

@umbynos umbynos force-pushed the umbynos/board_options branch from 3af30e4 to 11e2af5 Compare March 10, 2022 11:56
@umbynos umbynos merged commit 6303ba3 into master Mar 10, 2022
@umbynos umbynos deleted the umbynos/board_options branch March 10, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: CLI Related to the command line interface topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants