Skip to content

board list now returns partial results in case of errors #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Makes arduino-cli more resilient to errors.

  • What is the current behavior?

Calling arduino-cli board list runs all discoveries installed, by default builtin:serial-discovery and builtin:mdns-discovery are installed and ran.

If one of those discoveries return an error the whole command fails.

  • What is the new behavior?

arduino-cli board list now prints any error from discoveries and then eventual partial results obtains from other discoveries.

None.

  • Other information:

Fixes #1666.


See how to contribute

@silvanocerza silvanocerza added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 17, 2022
@silvanocerza silvanocerza requested a review from cmaglie February 17, 2022 10:03
@silvanocerza silvanocerza self-assigned this Feb 17, 2022
@silvanocerza silvanocerza merged commit dd48868 into master Feb 17, 2022
@silvanocerza silvanocerza deleted the scerza/partial-board-list branch February 17, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

board list command fails completely if even a single discovery can't be run
2 participants